feat: switch from abandoned redlock library to @sesamecare-oss/redlock #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, thanks for this module.
The original node-redlock library seems to be abandoned and in a broken state. I've created this pull request so you can switch to an alternative @sesamecare-oss/redlock.
Here's some background of the issues that made me create this PR:
In short, the original redlock library, as of the v5 release cannot be used in any modern NodeJS project, because of the Node16/NodeNext module resolution. This is already fixed upstream but never made it to the release and it doesn't look like it will happen anytime soon.
There's only one drawback of this PR i know of - loosing the ability to provide custom acquire/extend/release scripts, but IMHO this is unlikely critical for this library.