Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch from abandoned redlock library to @sesamecare-oss/redlock #723

Closed
wants to merge 1 commit into from

Conversation

dotslashx
Copy link

Hi, first of all, thanks for this module.

The original node-redlock library seems to be abandoned and in a broken state. I've created this pull request so you can switch to an alternative @sesamecare-oss/redlock.

Here's some background of the issues that made me create this PR:

In short, the original redlock library, as of the v5 release cannot be used in any modern NodeJS project, because of the Node16/NodeNext module resolution. This is already fixed upstream but never made it to the release and it doesn't look like it will happen anytime soon.

There's only one drawback of this PR i know of - loosing the ability to provide custom acquire/extend/release scripts, but IMHO this is unlikely critical for this library.

@anchan828
Copy link
Owner

anchan828 commented Oct 1, 2024

Hi @dotslashx, thanks for creating the PR.
I will carefully read this PR and the issues you shared within the next few days and respond accordingly. For now, switching packages might be a potential risk, so I may publishing a new package (e.g., @anchan828/nest-sesamecare-redlock 🤔).

@anchan828
Copy link
Owner

I released @anchan828/nest-sesamecare-redlock package. I've decided to provide it as a separate package after all. Please use it instead.

It is true that many people are facing difficulties, but since this issue has not yet been resolved, I felt that switching packages in a wrapper library like this repository is premature.

  • Even if switch at this point,@sesamecare-oss/redlock may not necessarily fix bugs or develop further. Therefore, there is a possibility that you will have to switch packages again.
  • There is a possibility that people using @anchan828/nest-redlock package are also using the node-redlock package in the same project. If this is the case, users will have to install two packages.

Since this repository is a thin wrapper, it will be easy to maintain even if we provide a similar package temporarily.

@dotslashx I was unable to merge this PR, but thank you for creating and proposing it.

@anchan828 anchan828 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants