Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore Android project structure and update configurations #1686

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

berhili098
Copy link

This pull request includes a series of changes to the Flutter project, primarily focusing on updating project configurations, improving Android build settings, and cleaning up unnecessary files. Below is a summary of the most important changes:

Project Configuration Updates:

  • Updated the example/.metadata file to include new revision and base revision values, and added a new platform entry for web.

Android Build Settings:

  • Updated example/android/app/build.gradle to use the new Gradle plugin syntax and updated various configurations to align with the latest Flutter and Android standards.
  • Updated example/android/settings.gradle to include build settings for the Flutter SDK and plugin management.
  • Updated example/android/gradle/wrapper/gradle-wrapper.properties to use Gradle 8.3.
  • Updated example/android/gradle.properties to increase JVM memory settings.

Cleanup and Removal of Unnecessary Files:

  • Removed Eclipse-specific project files (.project, .classpath, and .settings/org.eclipse.buildship.core.prefs) from the example/android directory. [1] [2] [3] [4] [5]
  • Removed outdated MainActivity files in example/android/app/src/main/java/com/mr/flutter/plugin/filepicker/example and example/android/app/src/main/kotlin/com/mr/flutter/plugin/filepicker/example. [1] [2]

These changes aim to modernize the project setup, improve build performance, and remove obsolete files to maintain a clean codebase.

- Updated Flutter project metadata with new revision and channel.
- Removed obsolete `.project` and `.settings` files from the Android directory.
- Simplified `build.gradle` files by removing unnecessary configurations and applying the Flutter Gradle plugin correctly.
- Enhanced `AndroidManifest.xml` files with updated permissions and application attributes.
- Updated Gradle wrapper to version 8.3 for improved performance and compatibility.
- Adjusted styles to support new themes and ensure proper display during app initialization.
Copy link
Collaborator

@navaronbracke navaronbracke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback on some things that probably need to be restored.

Thanks for looking into updating the Gradle setup, though!

example/test/widget_test.dart Outdated Show resolved Hide resolved
@@ -1,4 +1,3 @@
org.gradle.jvmargs=-Xmx1536M

org.gradle.jvmargs=-Xmx4G -XX:MaxMetaspaceSize=2G -XX:+HeapDumpOnOutOfMemoryError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this generated by flutter create ?

Copy link
Author

@berhili098 berhili098 Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

example/android/app/build.gradle Outdated Show resolved Hide resolved
example/android/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
example/android/build.gradle Outdated Show resolved Hide resolved
example/android/app/build.gradle Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants