Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary native windows support, part 2: standard library and libgerbil #1291
base: master
Are you sure you want to change the base?
Preliminary native windows support, part 2: standard library and libgerbil #1291
Changes from all commits
e4718f5
40340f8
9fbc750
26892fa
ef77b8c
af2310c
60b339a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also
errno = EINVAL;
orERROR_NOT_SUPPORTED
whenever wereturn -1;
like that so that the error message will be appropriate (unless there's a better E code under Windows)—if it'sERROR_NOT_SUPPORTED
we need it defined on the Scheme side, too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a systems programmer (I mostly work on algorithms, graphics, gamedev etc) so finding the "right thing to do" is difficult for me... But since I'll summarize current supported/unsupported things in the upcoming PR (documents and scripts), can we leave these problems for the future?