Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1283: fix interactive module reloading #1284

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Issue 1283: fix interactive module reloading #1284

merged 5 commits into from
Dec 11, 2024

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Dec 10, 2024

Closes #1283

  • Fixes interactive module reloading, so that a compiled module (and all its nested modules) can be properly reloaded
  • Adds load order tracking in the loader
  • Adds a list-modules procedure that allows you to inspect loader state
  • Fixes a deadlock in the loader caused by incorrect mutex release in reload-module!

@vyzo vyzo requested review from drewc and a team December 10, 2024 22:43
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit eea8b5d
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/6758c3f9792c270008c55377
😎 Deploy Preview https://deploy-preview-1284--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drewc
Copy link
Collaborator

drewc commented Dec 10, 2024

c/pasta lol: After looking: Where/when does it add the "~0" and friends? Or does it not fix that part?

Or:

if you actually (reload-module! "teggot/llsp/gccjit~0") instead of (reload-module! "teggot/llsp/gccjit") it works

Does the import order deal with that? I mean, does loading the "gccijt" then load the ~0 etc so reloading that reloads those?

  • drewc (Drew Crampsie)
    hates it when he can't see the solution to the problem because the problem no longer exists so does not need to be solved :P

@vyzo
Copy link
Collaborator Author

vyzo commented Dec 10, 2024

string-prefix? of the base does it.

@vyzo
Copy link
Collaborator Author

vyzo commented Dec 10, 2024

and yes of course, import order was added exactly to deal with this.

Copy link
Collaborator

@drewc drewc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vyzo vyzo merged commit 257c06a into master Dec 11, 2024
8 of 12 checks passed
@vyzo vyzo deleted the issue-1283 branch December 11, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gxi (reload ...) command cannot reload gxc-compiled modules
2 participants