Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -target js and friends! #1280

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Add -target js and friends! #1280

merged 6 commits into from
Dec 11, 2024

Conversation

drewc
Copy link
Collaborator

@drewc drewc commented Dec 8, 2024

This will hopefully become a JS implementation/port of Gerbil to the Universal Backend JavaScript version.

For now it is the bootstrap + a -target js gxc arg.

@drewc drewc marked this pull request as draft December 8, 2024 01:54
Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 2f7b210
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/6758dfeb43377100089eb3d3
😎 Deploy Preview https://deploy-preview-1280--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/gerbil/core/sugar.ss Outdated Show resolved Hide resolved
src/gerbil/compiler/driver.ss Outdated Show resolved Hide resolved
@vyzo
Copy link
Collaborator

vyzo commented Dec 8, 2024

also, make support

src/gerbil/gxc-main.ss Outdated Show resolved Hide resolved
src/gerbil/core/expander.ss Outdated Show resolved Hide resolved
src/gerbil/core/sugar.ss Outdated Show resolved Hide resolved
src/gerbil/core/sugar.ss Outdated Show resolved Hide resolved
src/gerbil/gxc-main.ss Show resolved Hide resolved
@vyzo
Copy link
Collaborator

vyzo commented Dec 8, 2024

Also, please add a pr description, even if it is just one sentence.

@vyzo
Copy link
Collaborator

vyzo commented Dec 9, 2024

I think we also want to add a --target <target> option to gerbil build for building projects with build specs and make.

Again, we dont have to do it in this pr, but lets pave the way.

@drewc
Copy link
Collaborator Author

drewc commented Dec 9, 2024 via email

@drewc drewc requested a review from vyzo December 10, 2024 23:40
@drewc drewc marked this pull request as ready for review December 11, 2024 00:28
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to rebootstrap before we can use it internally, but we can do that separately.

So good enough for now.

@drewc
Copy link
Collaborator Author

drewc commented Dec 11, 2024 via email

@drewc drewc merged commit 2f7bcd6 into master Dec 11, 2024
8 of 12 checks passed
@drewc drewc deleted the add-target branch December 11, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants