A couple of fixes #1015
Merged
A couple of fixes #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vyzo
commented
Oct 15, 2023
•
vyzo
commented
- Kill version.ss, the v0.19 development cycle has started.
- make clean should not try to delete things that don't exist and fail
- normalize load-path order: 1. GERBIL_LOADPATH 2. GERBIL_PATH/lib 3. GERBIL_HOME/lib (2 is excluded during the build)
First GERBIL_LOADPATH, then GERBIL_PATH, and then home
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
drewc
approved these changes
Oct 15, 2023
|
Shouldn't GERBIL_PATH come first? If I compile custom code, I expect it to be loaded, not some preexisting library that would somehow take precedence. |
|
LOADPATH is the override hook, it is not normally set. |
drewc
pushed a commit
to drewc/gerbil
that referenced
this pull request
Nov 29, 2023
0. Kill version.ss, the v0.19 development cycle has started. 1. make clean should not try to delete things that don't exist and fail 2. normalize load-path order: 1. GERBIL_LOADPATH 2. GERBIL_PATH/lib 3. GERBIL_HOME/lib (2 is excluded during the build)
This was referenced Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.