Best Fit Quality #987
Open
Best Fit Quality #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "Best Fit Quality" setting to the General Search Settings config. Defaults to Off If a perfect quality match cannot be found, it attempts a simple hierarchical logic search to try and guess the quality. Resolution -> Source -> Encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After finding several episodes in the logs that appeared to be valid search results (to me) but did not match any of the quality filters I added my own "Best Fit Quality" setting to the general search settings. It is a fallback if a perfect quality match cannot be found. The setting defaults to Off, but in practice has improved my search results and I'd prefer finding a "most likely correct" quality to an Unknown and therefore usually discarded quality.
I believe this is an improvement compared to choosing the "Any" quality setting for the show. I would rather categorize filenames that are pretty close to ideal and download those rather than settle for SDTV or lower quality.
Also: Relatively new to Git and not sure how to undo or ignore the random whitespace changes that appeared. Git doesn't allow committing whitespace-only changes. Thanks Git.