Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Ivanti.PackageStudio version 3.8.1 #204563

Merged
merged 6 commits into from
Jan 3, 2025
Merged

New package: Ivanti.PackageStudio version 3.8.1 #204563

merged 6 commits into from
Jan 3, 2025
+44 −0

Conversation

rovabunw
Copy link
Contributor

@rovabunw rovabunw commented Jan 1, 2025 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 1, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 1, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Jan 1, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 1, 2025
@rovabunw
Copy link
Contributor Author

rovabunw commented Jan 1, 2025

Hello @rovabunw,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

The installer URL is valid. Please review:

https://marketplace.ivanti.com/xchange/64b5b48e2ee9d6e08c3e6724/solution/663e0f991d314dc51e94fc00

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 1, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 2, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 2, 2025
stephengillie
stephengillie requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic Validation ended with:

Manifest Error: Duplicate field found in the manifest. [PackageUrl]

I missed this earlier, apologies.

manifests/i/Ivanti/PackageStudio/3.8.1/Ivanti.PackageStudio.installer.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot removed Changes-Requested Changes Requested Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 3, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Jan 3, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 3, 2025
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Jan 3, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) January 3, 2025 18:08
@stephengillie
Copy link
Collaborator

Verify:
image
image

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 09fdcb0 into microsoft:master Jan 3, 2025
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 3, 2025
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly Trenly requested changes

@stephengillie stephengillie stephengillie approved these changes

Assignees

@rovabunw rovabunw

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rovabunw @wingetbot @stephengillie @Trenly