Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Liquit.Workspace.PowerShell42 version 4.2.3735.5913 #204562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rovabunw
Copy link
Contributor

@rovabunw rovabunw commented Jan 1, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 1, 2025
Comment on lines +10 to +14
- DisplayName: Liquit Workspace PowerShell
Publisher: Liquit Software B.V.
DisplayVersion: 4.2.3735.5913
ProductCode: '{2E329CAA-7BD3-4D66-845D-2AA3BDF78771}'
UpgradeCode: '{A8A90B86-A5CB-46BA-8E01-BFD50757157D}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- DisplayName: Liquit Workspace PowerShell
Publisher: Liquit Software B.V.
DisplayVersion: 4.2.3735.5913
ProductCode: '{2E329CAA-7BD3-4D66-845D-2AA3BDF78771}'
UpgradeCode: '{A8A90B86-A5CB-46BA-8E01-BFD50757157D}'
- ProductCode: '{2E329CAA-7BD3-4D66-845D-2AA3BDF78771}'
UpgradeCode: '{A8A90B86-A5CB-46BA-8E01-BFD50757157D}'

DisplayVersion should be omitted when it is the same as PackageVersion
DisplayName should be omitted when it is the same as PackageName
Publisher should be omitted when it is the same as Publisher from the defaultLocale manifest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you suggest to use two ProductCode and UpgradeCode entries?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants