Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app advanced settings, execution aliases and apps for websites #146

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Jan 10, 2025


This PR addresses starts to address issue #98 . The following DSC resources are introduced:

  • AdvancedAppSettings
  • AppExecutionAliases
  • AppsForWebsites

Note

Tests for app execution aliases and AppsForWebsites are excluded, as I'm not expecting Windows Server 2022 to contain any App Installers.

Microsoft Reviewers: Open in CodeFlow

@Gijsreyn
Copy link
Contributor Author

@denelon

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Gijsreyn Gijsreyn changed the title Add app advanced settings and execution aliases Add app advanced settings, execution aliases and offlinemap Jan 12, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Gijsreyn Gijsreyn changed the title Add app advanced settings, execution aliases and offlinemap Add app advanced settings and execution aliases Jan 13, 2025

This comment has been minimized.

This comment has been minimized.

@Gijsreyn Gijsreyn changed the title Add app advanced settings and execution aliases Add app advanced settings, execution aliases and apps for websites Jan 15, 2025
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (4)

ADDLOCAL
Aic
Cdp
reparsepoint

These words are not needed and should be removed markdownlint VGpu

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:Gijsreyn/winget-dsc.git repository
on the windows-setting-apps branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/winget-dsc/actions/runs/12801054424/attempts/1'
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

⚠️ Warnings Count
⚠️ non-alpha-in-dictionary 3

See ⚠️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant