fix: resolve warnings in rust-script blocks and only fail warnings in CI #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshbg
previously approved these changes
Jan 31, 2024
wmmc88
force-pushed
the
clear-warnings
branch
from
2123156 to
84a0b95
Compare
hamzamust
approved these changes
Feb 2, 2024
rajeshbg
approved these changes
Feb 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html, deny(warnings) is an anti-pattern. Instead, warnings will now only fail in CI or when running cargo-make (in this repo). Warnings in rust-script blocks were also fixed.
pending merge of #79 . review top 3 commits