Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatusBarItem - proposed API for async hover #238297

Merged
merged 14 commits into from
Jan 21, 2025
Merged

StatusBarItem - proposed API for async hover #238297

merged 14 commits into from
Jan 21, 2025
+104 −18

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented Jan 20, 2025 •
edited by bpasero
Loading

for #234339

@lszomoru lszomoru self-assigned this Jan 20, 2025
@lszomoru lszomoru requested a review from bpasero January 20, 2025 14:14
@lszomoru lszomoru changed the title WIP - initial implementation StatusBarItem - proposed API for async hover Jan 20, 2025
@lszomoru lszomoru added the workbench-status Status bar label Jan 20, 2025
@lszomoru lszomoru added this to the January 2025 milestone Jan 20, 2025
bpasero
bpasero requested changes Jan 20, 2025
View reviewed changes
src/vscode-dts/vscode.proposed.statusBarItemTooltip.d.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/browser/mainThreadStatusBar.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/browser/mainThreadStatusBar.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHost.protocol.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostStatusBar.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostStatusBar.ts Show resolved Hide resolved
src/vs/workbench/api/common/extHostStatusBar.ts Show resolved Hide resolved
@lszomoru lszomoru requested a review from bpasero January 20, 2025 16:04
bpasero
bpasero requested changes Jan 20, 2025
View reviewed changes
src/vs/workbench/api/common/extHostStatusBar.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostStatusBar.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostStatusBar.ts Outdated Show resolved Hide resolved
src/vs/workbench/api/common/extHostStatusBar.ts Outdated Show resolved Hide resolved
@lszomoru lszomoru requested a review from bpasero January 20, 2025 19:29
@lszomoru
Copy link
Member Author

@bpasero, one piece that is still missing is to set the ariaLabel of the status bar entry when the hover provider is being run. Not really sure how to do that given that the hover provider is being passed to the hover. Would love to hear your thoughts on that. Thanks!

@bpasero bpasero marked this pull request as ready for review January 21, 2025 07:25
@bpasero
Copy link
Member

bpasero commented Jan 21, 2025

@bpasero, one piece that is still missing is to set the ariaLabel of the status bar entry when the hover provider is being run. Not really sure how to do that given that the hover provider is being passed to the hover. Would love to hear your thoughts on that. Thanks!

I do not see a way to do this when the tooltip is provided as function 🤔

@bpasero bpasero merged commit 57e5f4b into main Jan 21, 2025
8 checks passed
@bpasero bpasero deleted the lszomoru/status-hover-provider branch January 21, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diezocho diezocho diezocho approved these changes

@dbaeumer dbaeumer dbaeumer approved these changes

@bpasero bpasero bpasero approved these changes

Assignees

@lszomoru lszomoru

Labels
workbench-status Status bar
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
4 participants
@lszomoru @bpasero @dbaeumer @diezocho