Pick up latest TS for building VS Code

package.json

@@ -212,7 +212,7 @@
     "ts-node": "^10.9.1",
     "tsec": "0.2.7",
     "tslib": "^2.6.3",
-    "typescript": "^5.7.0-dev.20241104",
+    "typescript": "^5.8.0-dev.20241107",
     "typescript-eslint": "^8.8.0",
     "util": "^0.12.4",
     "webpack": "^5.94.0",
@@ -240,4 +240,4 @@
   "optionalDependencies": {
     "windows-foreground-love": "0.5.0"
   }
-}
+}

src/vs/platform/configuration/common/configuration.ts

@@ -279,7 +279,9 @@ function doRemoveFromValueTree(valueTree: any, segments: string[]): void {
 /**
  * A helper function to get the configuration value with a specific settings path (e.g. config.some.setting)
  */
-export function getConfigurationValue<T>(config: any, settingPath: string, defaultValue?: T): T {
+export function getConfigurationValue<T>(config: any, settingPath: string): T | undefined;
+export function getConfigurationValue<T>(config: any, settingPath: string, defaultValue: T): T;
+export function getConfigurationValue<T>(config: any, settingPath: string, defaultValue?: T): T | undefined {
 	function accessSetting(config: any, path: string[]): any {
 		let current = config;
 		for (const component of path) {

src/vs/platform/contextkey/browser/contextKeyService.ts

@@ -518,8 +518,8 @@ class OverlayContext implements IContext {
 
 	constructor(private parent: IContext, private overlay: ReadonlyMap<string, any>) { }
 
-	getValue<T>(key: string): T | undefined {
-		return this.overlay.has(key) ? this.overlay.get(key) : this.parent.getValue(key);
+	getValue<T extends ContextKeyValue>(key: string): T | undefined {
+		return this.overlay.has(key) ? this.overlay.get(key) : this.parent.getValue<T>(key);
 	}
 }
 

src/vs/platform/observable/common/wrapInHotClass.ts

@@ -5,7 +5,7 @@
 import { isHotReloadEnabled } from '../../../base/common/hotReload.js';
 import { IDisposable } from '../../../base/common/lifecycle.js';
 import { autorunWithStore, IObservable } from '../../../base/common/observable.js';
-import { BrandedService, GetLeadingNonServiceArgs, IInstantiationService } from '../../instantiation/common/instantiation.js';
+import { BrandedService, IInstantiationService } from '../../instantiation/common/instantiation.js';
 
 export function hotClassGetOriginalInstance<T>(value: T): T {
 	if (value instanceof BaseClass) {
@@ -19,7 +19,7 @@ export function hotClassGetOriginalInstance<T>(value: T): T {
  * When the wrapper is created, the original class is created.
  * When the original class changes, the instance is re-created.
 */
-export function wrapInHotClass0<TArgs extends BrandedService[]>(clazz: IObservable<Result<TArgs>>): Result<GetLeadingNonServiceArgs<TArgs>> {
+export function wrapInHotClass0<TArgs extends BrandedService[]>(clazz: IObservable<Result<TArgs>>): Result<TArgs> {
 	return !isHotReloadEnabled() ? clazz.get() : createWrapper(clazz, BaseClass0);
 }
 
@@ -61,7 +61,7 @@ class BaseClass0 extends BaseClass {
  * When the wrapper is created, the original class is created.
  * When the original class changes, the instance is re-created.
 */
-export function wrapInHotClass1<TArgs extends [any, ...BrandedService[]]>(clazz: IObservable<Result<TArgs>>): Result<GetLeadingNonServiceArgs<TArgs>> {
+export function wrapInHotClass1<TArgs extends [any, ...BrandedService[]]>(clazz: IObservable<Result<TArgs>>): Result<TArgs> {
 	return !isHotReloadEnabled() ? clazz.get() : createWrapper(clazz, BaseClass1);
 }
 

src/vs/platform/observable/common/wrapInReloadableClass.ts

@@ -13,7 +13,7 @@ import { BrandedService, GetLeadingNonServiceArgs, IInstantiationService } from
  * When the wrapper is created, the original class is created.
  * When the original class changes, the instance is re-created.
 */
-export function wrapInReloadableClass0<TArgs extends BrandedService[]>(getClass: () => Result<TArgs>): Result<GetLeadingNonServiceArgs<TArgs>> {
+export function wrapInReloadableClass0<TArgs extends BrandedService[]>(getClass: () => Result<TArgs>): Result<TArgs> {
 	return !isHotReloadEnabled() ? getClass() : createWrapper(getClass, BaseClass0);
 }
 

src/vs/workbench/services/preferences/common/preferencesModels.ts

@@ -95,7 +95,7 @@ abstract class AbstractSettingsModel extends EditorModel {
 		return undefined;
 	}
 
-	protected collectMetadata(groups: ISearchResultGroup[]): IStringDictionary<IFilterMetadata> {
+	protected collectMetadata(groups: ISearchResultGroup[]): IStringDictionary<IFilterMetadata> | null {
 		const metadata = Object.create(null);
 		let hasMetadata = false;
 		groups.forEach(g => {
@@ -208,7 +208,7 @@ export class SettingsEditorModel extends AbstractSettingsModel implements ISetti
 			allGroups: this.settingsGroups,
 			filteredGroups: filteredGroup ? [filteredGroup] : [],
 			matches,
-			metadata
+			metadata: metadata ?? undefined
 		};
 	}
 }
@@ -849,7 +849,7 @@ export class DefaultSettingsEditorModel extends AbstractSettingsModel implements
 				allGroups: this.settingsGroups,
 				filteredGroups,
 				matches,
-				metadata
+				metadata: metadata ?? undefined
 			} :
 			undefined;
 	}

src/vs/workbench/services/search/common/queryBuilder.ts

@@ -646,7 +646,7 @@ function splitGlobFromPath(searchPath: string): { pathPortion: string; globPorti
 	};
 }
 
-function patternListToIExpression(...patterns: string[]): glob.IExpression {
+function patternListToIExpression(...patterns: string[]): glob.IExpression | undefined {
 	return patterns.length ?
 		patterns.reduce((glob, cur) => { glob[cur] = true; return glob; }, Object.create(null)) :
 		undefined;