Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to default to recursive directory collapsing #231684

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Lancear
Copy link

@Lancear Lancear commented Oct 18, 2024

Closes #224267 - Always collapse directories recursively

@Lancear
Copy link
Author

Lancear commented Oct 18, 2024

@microsoft-github-policy-service agree

@thennothinghappened
Copy link

It would seem redundant to me to have the Alt behaviour remain as-is when this is enabled - why not have this option swap which behaviour requires Alt? That'd mean with recursive-as-default enabled, holding Alt would then cause a non-recursive collapse, whereas with this option disabled, the inverse is true.

@Lancear
Copy link
Author

Lancear commented Jan 6, 2025

I like that suggestion! Just to clarify the behaviour, could you please let me know if this is what you were thinking?

Current default behaviour:

  • collapse: collapses the single folder
  • open: opens the single folder
  • ALT collapse: collapses the folder recursively
  • ALT open: opens the folders recursively (seems to memorize the previously opened folders)

Video (collapse, open, ALT collapse, open, collapse, ALT open)

Settings.-.Pulse.-.Code.-.Oss.Dev.2025-01-06.14-13-33.mp4

My current implementation of the setting simply changes collapse to do the same as ALT collapse when enabled.

By inverting ALT for collapse we would do the following:

  • collapse: collapses the folder recursively
  • open: opens the single folder
  • ALT collapse: collapses the single folder
  • ALT open: opens the folders recursively (seems to memorize the previously opened folders)

Opening folders would stay the same as it wouldn't make much sense to always open the folders recursively again.

Is that correct?

@Amertyping
Copy link

sudo cp -f ~/ufw.backup/*rules /etc/ufw

@thennothinghappened
Copy link

By inverting ALT for collapse we would do the following:

  • collapse: collapses the folder recursively
  • open: opens the single folder
  • ALT collapse: collapses the single folder
  • ALT open: opens the folders recursively (seems to memorize the previously opened folders)

Opening folders would stay the same as it wouldn't make much sense to always open the folders recursively again.

Is that correct?

Yep! That's pretty much what I had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always collapse directories recursively
4 participants