Draft) Expose shell's environment to extension #228791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
changed the title
anthonykim1
commented
Sep 19, 2024
| export class ShellEnvironmentDetectionCapability extends Disposable implements IShellEnvDetectionCapability { | ||
| readonly type = TerminalCapability.ShellEnvironmentDetection; | ||
|
|
||
| // TODO: Type of envs should be { [key: string]: string | undefined } | undefined ?? |
There was a problem hiding this comment.
Does not need to be | undefined.
Capability will never be created where we dont receive it.
Co-authored-by: Daniel Imms <[email protected]>
Co-authored-by: Daniel Imms <[email protected]>
|
TODO: Create setting so that we dont always pass in environment variables to extension host by default. |
…ils for bash Co-authored-by: Daniel Imms <[email protected]>
|
Let's close this since it's superseded by #237415 and other follow ups |
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #227467
Bash/zsh/pwsh, etc -> capability -> env change event -> main thread -> env change event -> extension host -> SI change event (env, cwd, shell integration) -> ext