Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable corepack auto pin feature when executing npm view #210601

Merged
merged 4 commits into from
Apr 18, 2024
Merged

disable corepack auto pin feature when executing npm view #210601

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e9a5a9
disable corepack auto pin feature when executing npm view
frankli0324 Apr 17, 2024
7320679
configure additional env variables
frankli0324 Apr 17, 2024
dd21547
rewrite and lint comment
frankli0324 Apr 17, 2024
f2b36d3
Merge branch 'main' into patch/disable-corepack-autopin
frankli0324 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion extensions/npm/src/features/packageJSONContribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,13 @@ export class PackageJSONContribution implements IJSONContribution {
return new Promise((resolve, _reject) => {
const args = ['view', '--json', '--', pack, 'description', 'dist-tags.latest', 'homepage', 'version', 'time'];
const cwd = resource && resource.scheme === 'file' ? dirname(resource.fsPath) : undefined;
cp.execFile(npmCommandPath, args, { cwd }, (error, stdout) => {

// corepack npm wrapper would automatically update package.json. disable that behavior.
// COREPACK_ENABLE_AUTO_PIN disables the package.json overwrite, and
// COREPACK_ENABLE_PROJECT_SPEC makes the npm view command succeed
// even if packageManager specified a package manager other than npm.
const env = { COREPACK_ENABLE_AUTO_PIN: "0", COREPACK_ENABLE_PROJECT_SPEC: "0" };
cp.execFile(npmCommandPath, args, { cwd, env }, (error, stdout) => {
if (!error) {
try {
const content = JSON.parse(stdout);
Expand Down
Loading