-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply multiselects to scm/resourceGroup/context
menu commands (fix #92337)
#192172
base: main
Are you sure you want to change the base?
Conversation
/assign @lszomoru |
@lszomoru please consider adding this to the October 2023 milestone. |
Can this be merged soon? Or at least milestoned? |
@lszomoru I have done the merge necessary to bring this branch up to date with man, and have re-tested my changes. If possible please review and merge in time for next week's endgame. |
Updated from main and ready again for review & merging 🤞 |
@lszomoru I have updated from main and resolved the conflict. Please review. |
@lszomoru merging this would bring a big benefit for the SCM extension I maintain. Please consider it soon. |
@lszomoru any chance for April? |
Please accept this PR to close the linked issue, which is tagged |
@lszomoru please consider merging this. I have an extension that would benefit from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me
Please, review this minimal change. |
Maybe for August? 🙏 |
@lszomoru I have merged the ESM changes from main and re-tested. Please review 🙏 |
@lszomoru please can we have this in 1.95? |
@lszomoru Before I spend the time to resolve conflicts and update this branch I'd like to know what the chances are of you reviewing the PR. |
@lszomoru I have resolved the conflict and updated this branch from main, so it's now ready again for your consideration. |
This PR fixes #92337
One way to verify is to clone https://github.com/gjsjohnmurray/vscode-extension-samples/tree/show-vscode-92337 which modifies source-control-sample to add a second resource group, and contributes a command to
scm/resourceGroup/context
(both inline and on a context menu) that shows a notification of the label(s) of the selected group(s).