Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply multiselects to scm/resourceGroup/context menu commands (fix #92337) #192172

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #92337

One way to verify is to clone https://github.com/gjsjohnmurray/vscode-extension-samples/tree/show-vscode-92337 which modifies source-control-sample to add a second resource group, and contributes a command to scm/resourceGroup/context (both inline and on a context menu) that shows a notification of the label(s) of the selected group(s).

@gjsjohnmurray
Copy link
Contributor Author

/assign @lszomoru

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru please consider adding this to the October 2023 milestone.

@gjsjohnmurray
Copy link
Contributor Author

Can this be merged soon? Or at least milestoned?

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru I have done the merge necessary to bring this branch up to date with man, and have re-tested my changes. If possible please review and merge in time for next week's endgame.

@gjsjohnmurray
Copy link
Contributor Author

Updated from main and ready again for review & merging 🤞

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Feb 29, 2024

@lszomoru I have updated from main and resolved the conflict. Please review.

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru merging this would bring a big benefit for the SCM extension I maintain. Please consider it soon.

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru any chance for April?

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented May 3, 2024

Please accept this PR to close the linked issue, which is tagged help wanted.

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru please consider merging this. I have an extension that would benefit from it.

Copy link

@llgcode llgcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@llgcode
Copy link

llgcode commented Jul 10, 2024

Please, review this minimal change.

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru please consider merging this. I have an extension that would benefit from it.

Maybe for August? 🙏

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru I have merged the ESM changes from main and re-tested. Please review 🙏

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru please can we have this in 1.95?

@gjsjohnmurray
Copy link
Contributor Author

@lszomoru Before I spend the time to resolve conflicts and update this branch I'd like to know what the chances are of you reviewing the PR.

@lszomoru lszomoru added the scm General SCM compound issues label Dec 1, 2024
@gjsjohnmurray
Copy link
Contributor Author

@lszomoru I have resolved the conflict and updated this branch from main, so it's now ready again for your consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm General SCM compound issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCM - Provide multiple ScmResourceGroup in menu commands
3 participants