Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render hyperlinks with a dashed underline #7419

Closed
wants to merge 1 commit into from
Closed

Render hyperlinks with a dashed underline #7419

wants to merge 1 commit into from

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Aug 26, 2020 •
edited
Loading

Summary of the Pull Request

Renders hyperlinks with a dashed underline

References

#5001

PR Checklist

  • Closes #xxx
  • I work here
  • Tests added/passed
  • I've discussed this with core contributors already.

Detailed Description of the Pull Request / Additional comments

Introduced a new underline type (DashedUnderline), supports rendering for it, and uses it to render hyperlinks

Validation Steps Performed

link

@PankajBhojwani PankajBhojwani marked this pull request as ready for review August 27, 2020 00:04
@PankajBhojwani
Copy link
Contributor Author

Had to incorporate these changes into #7420 so am going to close this.

@DHowett DHowett deleted the dev/pabhoj/render_link branch February 5, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PankajBhojwani