[A11y] Treat last character as 'end of buffer' #10516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Accessibility
TODO
|
|
Most of the code that's submitted won't be touched, so a review would be much appreciated! |
|
Bug:
NVDA says, on each press of backspace: "h, h, s, s". NVDA should say (and said before this PR): "space, h, s, s". |
codeofdusk
reviewed
Jun 26, 2021
| { | ||
| return bufferSize.EndExclusive(); | ||
| } | ||
| // if we're already on/past the last RegularChar, |
There was a problem hiding this comment.
Not quite the last regular char. We need (user-entered) spaces, just not the extraneous thousands of newlines.
carlos-zamora
force-pushed
the
dev/cazamor/a11y-7000/text-attributes
branch
from
a99fa3c to
84fdf5a
Compare
ghost
closed this
ghost
deleted the branch
|
@carlos-zamora automerge broke this |
Urgh. I rebased it locally, but haven't pushed the changes yet. I'll fix this on Monday. Thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Updates our
UiaTextRangeto treat the last legible character as the end of the buffer. Doing so significantly improves performance of word navigation because screen readers no longer have to take into account the whitespace following the end of the prompt.This also fixes #7960. This bug was caused by the
UiaTextRangeoccasionally having its_blockRangemember set totrue. As a result, the screen reader would read the block range of text from "start" to "end" as if it was a block selection created by Alt+Mouse.References
#7000 - Epic
Closes #6986
Closes #7960
Detailed Description of the Pull Request / Additional comments
Coming soon!
Validation Steps Performed