.Net: Handle media types with parameters #10000
Open
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyMenshykh
added
openapi
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
RogerBarreto
reviewed
Jan 6, 2025
| @@ -352,7 +352,10 @@ private async Task<RestApiOperationResponse> ReadContentAndCreateOperationRespon | |||
| mediaType = mediaTypeFallback; | |||
| } | |||
|
|
|||
| if (!this._payloadFactoryByMediaType.TryGetValue(mediaType!, out var payloadFactory)) | |||
| // Remove media type parameters, such as x-api-version, from the "text/plain; x-api-version=2.0" media type string. | |||
| mediaType = mediaType!.Split(';').First(); | |||
There was a problem hiding this comment.
Might consider do a trimming as well?
Scenarios like " text/plain ; x-yz"
Is it possible to get the media type after the comma? (x-api=2.1; text/plain) ? If so pattern matching might worth.
Suggested change
| mediaType = mediaType!.Split(';').First(); | |
| mediaType = mediaType!.Split(';').First(); |
RogerBarreto
approved these changes
Jan 6, 2025
markwallace-microsoft
approved these changes
Jan 6, 2025
westey-m
reviewed
Jan 6, 2025
| // Remove media type parameters, such as x-api-version, from the "text/plain; x-api-version=2.0" media type string. | ||
| mediaType = mediaType!.Split(';').First(); | ||
|
|
||
| if (!this._payloadFactoryByMediaType.TryGetValue(mediaType, out var payloadFactory)) |
There was a problem hiding this comment.
Any risk of case differences when comparing? I see on the mozilla site it says that:
MIME types are case-insensitive but are traditionally written in lowercase. The parameter values can be case-sensitive.
https://developer.mozilla.org/en-US/docs/Web/HTTP/MIME_types#structure_of_a_mime_type
westey-m
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
This PR updates the RestApiOperationRunner class to be resilient to media types specified with parameters. It's a continuation of the first PR - #9959, where the OpenApiDocumentParser was updated to allow media types with parameters.