Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margins of auto formatted list. #2923

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

juliaroldi
Copy link
Contributor

@juliaroldi juliaroldi commented Jan 16, 2025

To make the list format consistent between list triggered by characters and list triggered by ribbon control, add the option to remove the list margins when starting a new list using AutoFormat Plugin.

@juliaroldi juliaroldi changed the title remove margins on Autoformat plugin Remove margins of auto formatted list. Jan 17, 2025
@juliaroldi juliaroldi marked this pull request as ready for review January 17, 2025 14:37
@JiuqingSong
Copy link
Collaborator

question, I tried to insert list from "1." and ribbon, but I didn't see any difference here. What is this PR fixing?

image

@juliaroldi
Copy link
Contributor Author

question, I tried to insert list from "1." and ribbon, but I didn't see any difference here. What is this PR fixing?

image

In the setListType function we have removeMargins parameter, I just added an option to remove the margin to the auto format options, so if we set the removeMargins to true in the ribbon control, we can also set to true in the AutoFormat options plugin.

@JiuqingSong
Copy link
Collaborator

question, I tried to insert list from "1." and ribbon, but I didn't see any difference here. What is this PR fixing?
image

In the setListType function we have removeMargins parameter, I just added an option to remove the margin to the auto format options, so if we set the removeMargins to true in the ribbon control, we can also set to true in the AutoFormat options plugin.

Got it. Thanks.

@juliaroldi juliaroldi merged commit f960478 into master Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants