Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo site icons #2918

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix demo site icons #2918

merged 1 commit into from
Jan 8, 2025

Conversation

JiuqingSong
Copy link
Collaborator

The old fluent ui font files for icons were removed, so we upgraded the fluent ui react version to 8.122.3 to fix the demo site icons.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • demo/index.html: Language not supported
  • index.html: Language not supported
  • package.json: Language not supported
  • packages/roosterjs-react/lib/ribbon/component/Ribbon.tsx: Evaluated as low risk
  • packages/roosterjs-react/lib/emoji/components/EmojiPane.tsx: Evaluated as low risk
  • packages/roosterjs-react/lib/emoji/components/EmojiStatusBar.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

packages/roosterjs-react/lib/emoji/type/EmojiPaneStyles.ts:6

  • Changing the type from IStyleSet to Object reduces type safety. Consider using a more specific type.
quickPicker: Object;
@JiuqingSong JiuqingSong merged commit 2099b7b into master Jan 8, 2025
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/fixicons branch January 8, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants