Fix builds and update to python 3.9 as default in tests #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/fix-builds-v2
branch
from
b592e39 to
51e024f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2593 +/- ##
==========================================
- Coverage 92.02% 87.89% -4.14%
==========================================
Files 95 113 +18
Lines 5370 6648 +1278
==========================================
+ Hits 4942 5843 +901
- Misses 428 805 +377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imatiach-msft
force-pushed
the
ilmat/fix-builds-v2
branch
from
51e024f to
630b82b
Compare
imatiach-msft
force-pushed
the
ilmat/fix-builds-v2
branch
from
630b82b to
5fa4dbb
Compare
imatiach-msft
force-pushed
the
ilmat/fix-builds-v2
branch
from
5fa4dbb to
df2dddf
Compare
imatiach-msft
force-pushed
the
ilmat/fix-builds-v2
branch
from
df2dddf to
366c10d
Compare
vinuthakaranth
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix builds and update to python 3.9 as default in tests
Copilot summary:
This pull request includes several changes to the GitHub workflows to update the supported Python versions and improve the artifact naming conventions. The most important changes include removing Python 3.7 and 3.8 from the supported versions, adding conditional steps for artifact uploads, and refining the naming conventions for uploaded artifacts.
Updates to Supported Python Versions:
pythonVersionmatrix in.github/workflows/CI-e2e-notebooks.yml,.github/workflows/CI-notebook.yml,.github/workflows/CI-python.yml, and.github/workflows/CI-raiwidgets-pytest.yml. [1] [2] [3] [4]Conditional Artifact Uploads:
Upload requirementssteps to only run onwindows-latestwith Python 3.9 in the respective workflows. [1] [2] [3] [4]Refining Artifact Naming Conventions:
notebookGroup,flights,operatingSystem, andpythonVersion. [1] [2] [3] [4]Additional Updates to Code Coverage Uploads:
Checklist