Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class View Search Case Fix #2498

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Class View Search Case Fix #2498

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ba2be
search case fix
Advitya17 Jan 19, 2024
9aa62c9
auto lint fixes
Advitya17 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/core-ui/src/lib/util/getFeatureOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function getFeatureOptions(
return {
data: {
categoricalOptions: options,
fullLabel: meta.label.toLowerCase()
fullLabel: meta.label.toLocaleLowerCase()
},
key,
text: meta.abbridgedLabel
Expand Down
8 changes: 4 additions & 4 deletions libs/fairness/src/lib/Controls/Insights.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ export class Insights extends React.Component<IInsightsProps> {
// description of model with best performance
const insights3 = localization.formatString(
localization.Fairness.ModelComparison.insightsText3,
this.props.selectedMetric.title.toLowerCase(),
this.props.selectedMetric.title.toLocaleLowerCase(),
this.props.selectedMetric.isMinimization
? formattedMinPerformance
: formattedMaxPerformance,
this.props.selectedFairnessMetric.title.toLowerCase(),
this.props.selectedFairnessMetric.title.toLocaleLowerCase(),
FormatMetrics.formatNumbers(
this.props.fairnessArray[
this.props.selectedMetric.isMinimization
Expand All @@ -101,12 +101,12 @@ export class Insights extends React.Component<IInsightsProps> {
// description of model with best fairness metric value
const insights4 = localization.formatString(
localization.Fairness.ModelComparison.insightsText4,
this.props.selectedMetric.title.toLowerCase(),
this.props.selectedMetric.title.toLocaleLowerCase(),
FormatMetrics.formatNumbers(
this.props.performanceArray[minFairnessValueIndex],
this.props.selectedPerformanceKey
),
this.props.selectedFairnessMetric.title.toLowerCase(),
this.props.selectedFairnessMetric.title.toLocaleLowerCase(),
formattedMinFairnessValue
);

Expand Down
6 changes: 3 additions & 3 deletions libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/CohortToolBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class CohortToolBar extends React.Component<
public componentDidMount(): void {
const cohortNames: string[] = [];
this.props.cohorts.forEach((cohort: ErrorCohort) => {
cohortNames.push(cohort.cohort.name.toLowerCase());
cohortNames.push(cohort.cohort.name.toLocaleLowerCase());
});
const selectionCount: number = this.props.selectedIndices.length;
this.setState({ cohortNames, selectionCount });
Expand All @@ -72,7 +72,7 @@ export class CohortToolBar extends React.Component<
if (prevProps.cohorts !== this.props.cohorts) {
const cohortNames: string[] = [];
this.props.cohorts.forEach((cohort: ErrorCohort) => {
cohortNames.push(cohort.cohort.name.toLowerCase());
cohortNames.push(cohort.cohort.name.toLocaleLowerCase());
});
this.setState({ cohortNames });
}
Expand Down Expand Up @@ -180,7 +180,7 @@ export class CohortToolBar extends React.Component<
this.setState({
errorMessage: localization.InterpretVision.Cohort.errorNumSelected
});
} else if (this.state.cohortNames.includes(cohortName.toLowerCase())) {
} else if (this.state.cohortNames.includes(cohortName.toLocaleLowerCase())) {
this.setState({
errorMessage: localization.InterpretVision.Cohort.errorCohortName
});
Expand Down
2 changes: 1 addition & 1 deletion libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class ImageList extends React.Component<
}

private getFilteredItems(): IVisionListItem[] {
const searchValue = this.props.searchValue.toLowerCase();
const searchValue = this.props.searchValue.toLocaleLowerCase();
let filteredItems: IVisionListItem[] = this.props.items;
if (searchValue.length > 0) {
filteredItems = getFilteredDataFromSearch(
Expand Down
6 changes: 3 additions & 3 deletions libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TableList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class TableList extends React.Component<
this.props.searchValue !== prevProps.searchValue
) {
const filteredItems: IVisionListItem[] = this.getFilteredItems();
const searchVal = this.props.searchValue.toLowerCase();
const searchVal = this.props.searchValue.toLocaleLowerCase();
const groups: IGroup[] =
searchVal.length === 0
? this.getGroups()
Expand Down Expand Up @@ -118,7 +118,7 @@ export class TableList extends React.Component<

items = items.concat(this.props.successInstances);
items = items.concat(this.props.errorInstances);
const searchValue = this.props.searchValue.toLowerCase();
const searchValue = this.props.searchValue.toLocaleLowerCase();
if (searchValue.length === 0) {
return items;
}
Expand Down Expand Up @@ -155,7 +155,7 @@ export class TableList extends React.Component<
filteredItems: IVisionListItem[],
groups: IGroup[]
): IGroup[] {
const searchValue = this.props.searchValue.toLowerCase();
const searchValue = this.props.searchValue.toLocaleLowerCase();
if (searchValue.length === 0) {
return groups;
}
Expand Down
4 changes: 2 additions & 2 deletions libs/interpret-vision/src/lib/VisionExplanationDashboard/utils/getFilteredData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function includesSearchVal(
searchVal: string
): boolean {
if (Array.isArray(labels)) {
return labels.some((label) => label.toLowerCase().includes(searchVal));
return labels.some((label) => label.toLocaleLowerCase().includes(searchVal.toLocaleLowerCase()));
}
return labels.toLowerCase().includes(searchVal);
return labels.toLocaleLowerCase().includes(searchVal.toLocaleLowerCase());
}
2 changes: 1 addition & 1 deletion ...assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/CohortStatsHeatmap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export class CohortStatsHeatmap extends React.Component<
localization.ModelAssessment.ModelOverview
.tableMetricTooltip,
// make metric name lower case in sentence
this.series.xAxis.categories[this.point.x].toLowerCase(),
this.series.xAxis.categories[this.point.x].toLocaleLowerCase(),
cohortNameBold,
pointValue === null
? localization.ModelAssessment.ModelOverview.nA
Expand Down
2 changes: 1 addition & 1 deletion ...ssessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/FairnessMetricTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class FairnessMetricTable extends React.Component<
: localization.ModelAssessment.ModelOverview
.tableRatioTooltip,
// make metric name lower case in sentence
this.series.xAxis.categories[point.x].toLowerCase(),
this.series.xAxis.categories[point.x].toLocaleLowerCase(),
pointValue,
min,
`<b>${point.minCohort}</b>`,
Expand Down
Loading