fix vision dashboard flyout accessibility on smaller screen size #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
imatiach-msft
force-pushed
the
ilmat/fix-flyout-vision-accessibility
branch
from
dfd0ab7 to
d0ff1a8
Compare
1 similar comment
Advitya17
approved these changes
Nov 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix vision dashboard flyout accessibility on smaller screen size
Repro:
Navigate the "Vision Data Explorer" section, navigate the "Image Explorer View" tab and all the controls present under it.
Navigate to "Error Instances/Success instances" section.
Select an Error instance "Can".
"Selected Instance" dialog opens. Navigate all the controls present on the dialog.
Observe and verify whether Controls present under "Error Instances" section on "Selected Instance" dialog are truncated after setting the viewport to 320*256 pixel or not.
Background:
Low vision users who depend on zooming functionality for better readability will be impacted if the controls present under page/dialog are truncated after setting the viewport to 320*256 pixel. As a result, users will miss the important information present under the dialog.
Issue:
All the texts present under "Error Instances" section on "Selected Instance" dialog are truncated after setting the viewport to 320*256 pixel.
Text such as "X Error instances", "Image 26", "Predicted: can" and "Ground truth: water bottle" are truncated after setting the viewport to 320*256 pixel.
Dialog controls are truncated even after scrolling the dialog using arrow keys.
Expected Result:
After setting the viewport to 320*256 pixel, all the text such as "X Error instances", "Image 26", "Predicted: can" and "Ground truth: water bottle" present under "Selected Instance" dialog should be clearly visible without any truncation.
Video before fix:
FlyoutBeforeFix.mp4
Video after fix:
FlyoutAfterFix.mp4
Checklist