Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added aria-labels to buttons #2418

Merged
merged 13 commits into from
Nov 22, 2023
Merged

Added aria-labels to buttons #2418

merged 13 commits into from
Nov 22, 2023

Conversation

Advitya17
Copy link
Collaborator

Fixed screen reader accessibility for buttons

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

1 similar comment
@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/accessible_buttons/dashboard/index.html

@Advitya17 Advitya17 merged commit 96b3574 into main Nov 22, 2023
86 checks passed
@Advitya17 Advitya17 deleted the agemawat/accessible_buttons branch November 22, 2023 16:58
@Advitya17 Advitya17 mentioned this pull request Dec 5, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaugup gaugup gaugup approved these changes

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Advitya17 @imatiach-msft @gaugup