fallback to request if socket connection fails for object detection and question answering metrics for backcompat #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
tongyu-microsoft,
vinuthakaranth,
xuke444,
RubyZ10 and
hawestra
as code owners
imatiach-msft
force-pushed
the
ilmat/socket-backcompat
branch
from
3b478cb to
3059504
Compare
…nd question answering metrics for backcompat
imatiach-msft
force-pushed
the
ilmat/socket-backcompat
branch
from
3059504 to
319eb21
Compare
1 similar comment
RubyZ10
approved these changes
Nov 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fallback to request if socket connection fails for object detection and question answering metrics for backcompat
This is to ensure that users with older versions of the python package but new UI can still view metrics for QA and object detection scenarios. Also, this ensures that users who may be in environments where socket connections are disallowed may still be able to view metrics if requests are allowed (and the request is small or the timeout is large).
Checklist