Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.76] [Telemetry] Add RnwNewArch to MSBuildProperties #14237

Open
wants to merge 2 commits into
base: 0.76-stable
Choose a base branch
from

Conversation

danielayala94
Copy link
Contributor

@danielayala94 danielayala94 commented Jan 4, 2025

Description

Backport #14208 to 0.76.

Add RnwNewArch and UseFabric properties to MSBuildProperties, indicating if the project is using Paper or Fabric.

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

By using telemetry data, we want to determine the adoption level of Fabric.

Resolves #14047

What

Included RnwNewArch and UseFabric in the properties written into msproperties.g.json (via OutputMSBuildProperties.targets), which are picked up by run-windows to pass all the properties as extraProps for telemetry logging.

Screenshots

image

Testing

Ran run-windows in a debugger and verified that RnwNewArch and UseFabric are written into msproperties.g.json and they are passed to Telemetry.trackCommandEvent().

Changelog

No

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@danielayala94 danielayala94 requested a review from a team January 4, 2025 00:00
@danielayala94 danielayala94 requested a review from a team as a code owner January 4, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant