Log error code from hermes.dll load failure #14236
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Surface an error code indicating why hermes.dll didn't load.
Type of Change
Erase all that don't apply.
Why
We currently are seeing cases where hermes.dll is not loaded. However, Watson cabs can't tell what is the root cause of the loading failure.
What
Added a
CRASH_ON_ERRORcheck right after hermes.dll loading attempt, callingGetLastError()to retrieve theLoadLibraryWin32 API error.Screenshots
N/A
Testing
Ran
run-windows, both in a successful scenario and a failure scenario (in this case, intentionally removed hermes.dll from the app files, then verified the app crashes at the newly introduced code).Changelog
No
Add a brief summary of the change to use in the release notes for the next release.
Microsoft Reviewers: Open in CodeFlow