Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up LongLivedObjectCollection created by RN Windows #12934

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Change files

90f88e1
Select commit
Loading
Failed to load commit list.
Open

Cleans up LongLivedObjectCollection created by RN Windows #12934

Change files
90f88e1
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR (Build 🔨 Universal Build X64Debug) failed Apr 9, 2024 in 7m 52s

Build 🔨 Universal Build X64Debug failed

Annotations

Check failure on line 307 in vnext\Shared\OInstance.cpp

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR (Build 🔨 Universal Build X64Debug)

vnext\Shared\OInstance.cpp#L307

vnext\Shared\OInstance.cpp(307,62): Error C2661: 'facebook::react::InstanceImpl::InstanceImpl': no overloaded function takes 11 arguments

Check failure on line 16 in vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR (Build 🔨 Universal Build X64Debug)

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h#L16

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h(16,83): Error C2660: 'facebook::react::LongLivedObjectCollection::get': function does not take 1 arguments

Check failure on line 22 in vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR (Build 🔨 Universal Build X64Debug)

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h#L22

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h(22,12): Error C2065: 'runtime_': undeclared identifier

Check failure on line 26 in vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR (Build 🔨 Universal Build X64Debug)

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h#L26

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h(26,73): Error C2665: 'facebook::react::LongLivedObject::LongLivedObject': no overloaded function could convert all the argument types

Check failure on line 16 in vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR (Build 🔨 Universal Build X64Debug)

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h#L16

vnext\Microsoft.ReactNative.Cxx\JSI\LongLivedJsiValue.h(16,83): Error C2660: 'facebook::react::LongLivedObjectCollection::get': function does not take 1 arguments