Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for running single flow nodes with nested dict inputs #3881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pjanowski
Copy link

@pjanowski pjanowski commented Dec 8, 2024

Description

Inputs like ${parent_node.output.result.inner_key} will fail because of how the inputs are currently written to the jsonl inputs file. Eg.

{"parent_node.output.result.inner_key":{"result":{"inner_key1":"foo","inner_key2":"bar"},"metrics":{"mertric_1":1.2}}

This is different behavior than when running entire flow where the input is always keyed on "parent_node.output.result" rather than "parent_node.output.result.inner_key".

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • [] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

Fixes #3882

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • [ x There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Inputs like ${parent_node.output.result.inner_key} will fail because of how the inputs are currently written to the jsonl inputs file. Eg. 

{"parent_node.output.result.inner_key":{"result":{"inner_key1":"foo","inner_key2":"bar"},"metrics":{"mertric_1":1.2}}

This is different behavior than when running entire flow where the input is always keyed on "parent_node.output.result" rather than "parent_node.output.result.inner_key".
@pjanowski pjanowski requested a review from a team as a code owner December 8, 2024 02:58
add whitespace around operator
@pjanowski pjanowski changed the title Fix bug for running single flow nodes with inner dict inputs Fix bug for running single flow nodes with nested dict inputs Dec 8, 2024
Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Dec 22, 2024
@pjanowski
Copy link
Author

active

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Dec 23, 2024
Copy link

github-actions bot commented Jan 7, 2025

SDK CLI Global Config Test Result patch-1

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4f0dcbb.

Copy link

github-actions bot commented Jan 7, 2025

Executor Unit Test Result patch-1

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4f0dcbb.

Copy link

github-actions bot commented Jan 7, 2025

Executor E2E Test Result patch-1

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4f0dcbb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Single node test runs with nested dict parent node inputs InvalidReferenceProperty error.
1 participant