Fix for missing Label for platform on docker container #3784
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In what scenario would you have a container without the platform label? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix that should be implemented in case of missing docker container Label
platform.Get-BcContainerPlatformVersioncan return an empty string, which results in as a soft error, hard to track because it runs inside of container.The error:
Cannot convert value "" to type "System.Version". Error: "Version string portion was too short or too long. (Parameter 'input')"I tried to be consistent how you handle soft errors for
Get-BcContainerPlatformVersion. I usedGet-BcContainerNavVersionas a fallback and additionally added a warning to point the user in the right direction to fix it.