Rust: ConnectionEvent enum #4786
Draft
+275
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
commented
Jan 31, 2025
| @@ -0,0 +1,178 @@ | |||
| use std::ffi::c_void; | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4786 +/- ##
==========================================
- Coverage 87.38% 86.06% -1.33%
==========================================
Files 56 56
Lines 17400 17400
==========================================
- Hits 15205 14975 -230
- Misses 2195 2425 +230 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Jan 31, 2025
| @@ -85,6 +85,19 @@ impl core::fmt::Display for StatusCode { | |||
| } | |||
| } | |||
|
|
|||
| impl StatusCode { | |||
| /// If the ffi status is unknown/undefined, use not_supported by default. | |||
| /// MsQuic returns an undefined status code should not happen ideally, | |||
There was a problem hiding this comment.
MsQuic absolutely can return other stays codes from the platform. I think we need a better solution for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a safe ConnectionEvent enum implementation. Added code to convert from ffi ConectionEvent union.
Added StatusCode::from_raw_lossy().
Removed manual ffi code for ConnectionEvent.
Added StreamRef as an none-owning handle wrapper used in ConnectionEvent.
Testing
Changed the existing test to use the new ConnectionEvent enum.
Documentation
NA