Add support for setting TypeOfService/TrafficClass on connections #4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Jan 21, 2025
anrossi
commented
Jan 25, 2025
anrossi
commented
Jan 26, 2025
| CMsg = (PWSACMSGHDR)&CMsgBuffer[CMsgLen]; | ||
| CMsgLen += WSA_CMSG_SPACE(sizeof(INT)); | ||
| CMsg->cmsg_level = | ||
| Route->LocalAddress.si_family == QUIC_ADDRESS_FAMILY_INET ? |
There was a problem hiding this comment.
LocalAddress might be the wrong address to use; if trying to send to an IPv4 address using a dual-mode socket, you need to set the IPv4 IP_TOS, instead of the IPV6_TCLASS
nibanks
reviewed
Jan 27, 2025
nibanks
reviewed
Jan 27, 2025
nibanks
reviewed
Jan 27, 2025
nibanks
reviewed
Jan 27, 2025
| @@ -7207,27 +7228,55 @@ QuicConnParamGet( | |||
| } | |||
|
|
|||
| case QUIC_PARAM_CONN_ORIG_DEST_CID: | |||
|
|
|||
There was a problem hiding this comment.
nit: don't modify code that's not relevant to this PR?
nibanks
reviewed
Jan 27, 2025
nibanks
reviewed
Jan 27, 2025
anrossi
commented
Jan 27, 2025
anrossi
commented
Jan 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
==========================================
- Coverage 87.38% 86.74% -0.64%
==========================================
Files 56 56
Lines 17400 17421 +21
==========================================
- Hits 15205 15112 -93
- Misses 2195 2309 +114 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4767. Add support for applications to set the Type of Service/Traffic Class field all traffic sent from a connection.
Testing
TBD
Documentation
Updated the settings document with the new get/set param.