Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSSL 3 feature support to CI and configuration #4736

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

masa-koz
Copy link
Contributor

@masa-koz masa-koz commented Jan 4, 2025

Description

This pull request introduces support for the openssl3 feature across multiple files. The most important changes include updates to the workflow configuration, the feature list in Cargo.toml, and the build script to accommodate the new feature.

Support for openssl3 feature:

  • .github/workflows/cargo.yml: Added --features openssl3 and --features openssl3,static to the matrix of features.
  • Cargo.toml: Added openssl3 to the list of features.
  • scripts/build.rs: Updated the build script to define QUIC_TLS as openssl3 when the openssl3 feature is enabled.

Testing

  • cargo test --features openssl3
  • cargo test --features openssl3,static

Documentation

TBD

@masa-koz masa-koz requested a review from a team as a code owner January 4, 2025 09:21
@@ -47,6 +47,7 @@ include = [
[features]
default = []
schannel = []
openssl3 = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since openssl3 is a separate submodule, we need to update include paths above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me think we need automation to validate all this stuff. I wonder if we should add a prereq step to our GitHub action that fake publishes the crate locally, then uploads it. Then all other jobs work off the crate, not a git clone.

@nibanks nibanks added external Proposed by non-MSFT Language: Rust Related to the Rust interop layer labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Proposed by non-MSFT Language: Rust Related to the Rust interop layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants