Event Queue Completion Refactor #4732
Open
+757
−807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4732 +/- ##
==========================================
- Coverage 87.20% 86.58% -0.62%
==========================================
Files 56 56
Lines 17363 17378 +15
==========================================
- Hits 15141 15047 -94
- Misses 2222 2331 +109 ☔ View full report in Codecov by Sentry. |
ami-GS
reviewed
Jan 6, 2025
| @@ -959,6 +959,16 @@ CxPlatInternalEventWaitWithTimeout( | |||
| #include <liburing.h> | |||
| typedef struct io_uring CXPLAT_EVENTQ; | |||
| typedef struct io_uring_cqe* CXPLAT_CQE; | |||
| typedef | |||
| _IRQL_requires_max_(PASSIVE_LEVEL) | |||
There was a problem hiding this comment.
This annotation is not needed for posix?
ami-GS
reviewed
Jan 6, 2025
Comment on lines
+1078
to
+1083
| typedef | ||
| void | ||
| (CXPLAT_EVENT_COMPLETION)( | ||
| _In_ CXPLAT_CQE* Cqe | ||
| ); | ||
| typedef CXPLAT_EVENT_COMPLETION *CXPLAT_EVENT_COMPLETION_HANDLER; |
There was a problem hiding this comment.
These can be declared in quic_platform.h?
_posix.h and _winuser.h have same
ami-GS
reviewed
Jan 6, 2025
| void | ||
| DataPathProcessCqe( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the CxPlat event queue interface to have completions execute callback functions instead of call hardcoded functions with type value.
Testing
Existing CI/CD
Documentation
N/A - Internal (for now)