-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TestCategory and MachineName to JUnitReport #3416
base: master-se-1
Are you sure you want to change the base?
Conversation
e814714
to
9a62be8
Compare
9a62be8
to
8775898
Compare
8775898
to
f553c7d
Compare
@microsoft-github-policy-service agree company="Microsoft" |
@@ -323,47 +330,48 @@ Class TestController { | |||
} | |||
} | |||
if (!$allTests) { | |||
Throw "Not able to collect any test cases from XML files" | |||
Write-LogWarn "Not able to collect any test cases from XML files" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically , if a pipeline run get cancelled just after all test cases passed, but before the report generation, so in this case if we rerun. "i changed the script in pipeline to run only failed test case."
so in rerun 0 testcases will be there, but task can be sucessfully executed as we only have report generation left in this rerun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add return here? and keep following contents not changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
f553c7d
to
a4beaa0
Compare
a4beaa0
to
d99eab7
Compare
Add TestCategory and MachineName to JUnitReport
Update ExitCode=0 when 0 test case detected, this is done as "if a pipeline fails/cancelled just after all test cases ran and passed but before the summary generation, in rerun our pipeline optimisation script will return "0 test case" and this should be a valid case and only report should be generated and rerun and pipeline should pass.