Test ksc-mlir on examples from test/ksc #663
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Created issue #664 for reinstating these tests.) |
dcrc2
changed the title
|
Why delete rather than e.g. comment out? Will the reinstatement have to fish out files from history? |
(Sorry for the confusion, I've now added the new location of these tests to this PR, though I still need to fix the list of test examples in the new file.) |
dcrc2
force-pushed
the
dcrc2/remove-mlir-examples
branch
3 times, most recently
from
2ec314a to
37cd5f7
Compare
awf
approved these changes
Mar 31, 2021
These can be reinstated later, but the examples will need to be run through ksc first, rather than expecting ksc-mlir to be able to process these files directly. (We don't expect ksc-mlir to be able to deal with gdefs, for example.)
dcrc2
force-pushed
the
dcrc2/remove-mlir-examples
branch
from
37cd5f7 to
872d9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes tests which were previously disabled. These tests are moved to a new script, which runs the examples through ksc first: this is necessary as ksc-mlir cannot process these files directly. (We don't expect ksc-mlir to be able to deal with gdefs, for example.)
Draft PR: these tests will not work until ksc-mlir supports structured names and tuple-unpacking lets (and quite likely some other fixes as well).