-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using (*JsonParseNode).GetXValue methods it panics fix #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I did leave one question about the impact here.
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
reopening, it closed, by mistake, when I went to resolve the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
Can you also add an entry to the changelog please? (patch bump, changed, today's date)
@andrueastman for final review and merge/publish
Just added, let me know if any adjustments should be made to the verbiage! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution here @michaeldcanady
Added utils for converting from like types to others:
ex:
doesn't convert between non-like types:
bool(true) -/-> "true"
int8(1) -/-> bool(true)
Fixes #142