Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy: strengthen bundle id validation #285

Merged
merged 2 commits into from
Jan 7, 2025
Merged

policy: strengthen bundle id validation #285

merged 2 commits into from
Jan 7, 2025

Conversation

Redent0r
Copy link

@Redent0r Redent0r commented Jan 6, 2025 •
edited
Loading

Ensure bundle id read from annotation matches expected format

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary
Test Methodology

test run: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=706792&view=results

danmihai1
danmihai1 requested changes Jan 7, 2025
View reviewed changes
src/tools/genpolicy/rules.rego Outdated Show resolved Hide resolved
@Redent0r Redent0r force-pushed the saulparedes/strengthen_bundle_id_validation branch from 58bfb1a to d23e177 Compare January 7, 2025 17:49
@Redent0r
policy: strengthen bundle id validation
45ef622 
Ensure bundle id read from annotation matches expected format

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r
samples: update samples
724d9bf 
Update sample annotations

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r Redent0r force-pushed the saulparedes/strengthen_bundle_id_validation branch from d23e177 to 724d9bf Compare January 7, 2025 17:52
@Redent0r Redent0r requested a review from danmihai1 January 7, 2025 17:54
@Redent0r Redent0r added the upstream/missing PRs that are yet to be upstreamed label Jan 7, 2025
@Redent0r Redent0r marked this pull request as ready for review January 7, 2025 21:25
@Redent0r Redent0r requested review from a team as code owners January 7, 2025 21:25
@Redent0r Redent0r merged commit f703a57 into msft-main Jan 7, 2025
74 of 121 checks passed
@Redent0r Redent0r deleted the saulparedes/strengthen_bundle_id_validation branch January 7, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmihai1 danmihai1 danmihai1 approved these changes

Assignees
No one assigned
Labels
upstream/missing PRs that are yet to be upstreamed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Redent0r @danmihai1