forked from kata-containers/kata-containers
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Enable confidential ephemeral volumes #230
Draft
sprt
wants to merge
3
commits into
msft-main
Choose a base branch
from
sprt/node-local
base: msft-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprt
added
upstream/not-needed
PRs that will not be upstreamed (e.g. internal)
upstream/missing
PRs that are yet to be upstreamed
and removed
upstream/not-needed
PRs that will not be upstreamed (e.g. internal)
labels
Sep 11, 2024
danmihai1
reviewed
Sep 11, 2024
1 task
This enables confidential ephemeral storage by allowing the CSI driver to pass options confidential=true and ephemeral=true. When these options are provided, the agent will generate a random encryption key and use cryptsetup to encrypt the host device, format it as an ext4 filesystem, and expose it to the container. Signed-off-by: Aurélien Bombo <[email protected]>
New changes:
Next step: genpolicy changes. |
New changes: added genpolicy support. |
This adds a new setting to genpolicy to support confidential ephemeral volumes. Signed-off-by: Aurélien Bombo <[email protected]>
Using a symlink would create a cycle after calling this script again when copying the final configuration at line 74 so we just use cp instead. Signed-off-by: Aurélien Bombo <[email protected]>
Looks good to me from what I understand. My only feedback (possibly for a different PR) would be how to go about testing this. Would it be roughly something like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missing
label (orupstream/not-needed
) has been set on the PR.Summary
Please see commit messages. Note that this approach follows the driver-shim interface design (with the new metadata driver options) that we agreed to propose upstream with Intel. When we sync our fork with upstream, the agent code will look much different, but those agent changes should be transparent to the end user.
Upstream proposal: confidential-containers/confidential-containers#247
Depends on:
Migration flows:
Test Methodology
Local testing