For each repo stop on error #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In microsoft#623, it was reported that the regularly scheduled maintenance stops if one repo in the middle of the list was found to be missing. This is undesirable, and points out a gap in the design of `git for-each-repo`: We need a mode where that command does not stop on an error, but continues to try running the specified command with the other repositories. Imitating the `--keep-going` option of GNU make, this commit teaches `for-each-repo` the same trick: to continue with the operation on all the remaining repositories in case there was a problem with one repository, still setting the exit code to indicate an error occurred. Helped-by: Eric Sunshine <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
In microsoft#623, it was reported that maintenance stops on a missing repository, omitting the remaining repositories that were scheduled for maintenance. This is undesirable, as it should be a best effort type of operation. It should still fail due to the missing repository, of course, but not leave the non-missing repositories in unmaintained shapes. Let's use `for-each-repo`'s shiny new `--keep-going` option that we just introduced for that very purpose. This change will be picked up when running `git maintenance start`, which is run implicitly by `scalar reconfigure`. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
for-each-repo-stop-on-error
branch
from
805c24b to
86c0809
Compare
derrickstolee
approved these changes
Apr 17, 2024
|
Thanks for working on this, @dscho! |
|
The reviews on the Git mailing list so far look favorable (just two nits, which I have addressed already). So I'm going to merge this PR. If any further iterations are required on the Git mailing list, I will open follow-up PRs. |
dscho
added a commit
that referenced
this pull request
Apr 23, 2024
This is an early version of patches I am about to send upstream: gitgitgadget#1719. This addresses #623.
dscho
added a commit
that referenced
this pull request
Apr 23, 2024
This is an early version of patches I am about to send upstream: gitgitgadget#1719. This addresses #623.
dscho
added a commit
that referenced
this pull request
Apr 24, 2024
This is an early version of patches I am about to send upstream: gitgitgadget#1719. This addresses #623.
dscho
added a commit
that referenced
this pull request
Apr 29, 2024
This is an early version of patches I am about to send upstream: gitgitgadget#1719. This addresses #623.
dscho
added a commit
that referenced
this pull request
May 14, 2024
This is an early version of patches I am about to send upstream: gitgitgadget#1719. This addresses #623.
dscho
added a commit
that referenced
this pull request
Jun 3, 2024
This is an early version of patches I am about to send upstream: gitgitgadget#1719. This addresses #623.
dscho
added a commit
that referenced
this pull request
Jul 17, 2024
This is an early version of patches I am about to send upstream: gitgitgadget#1719. This addresses #623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early version of patches I am about to send upstream: gitgitgadget#1719.
This addresses #623.