Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --verbose option to bpf2c #4140

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

Alan-Jowett
Copy link
Member

Resolve: #3879

Description

Add option to print verbose verification results on failure.

Testing

CI/CD

Documentation

No.

Installation

No.

@dthaler
Copy link
Collaborator

dthaler commented Jan 15, 2025

While the changes look good, I'm concerned about the "Documentation: No" in the PR description.
I checked the docs, and the README says:

See our basic eBPF tutorial and our tutorial on debugging eBPF verification failures.

However, neither of those mention bpf2c, and I believe both walkthroughs would eventually fail on a native-only build.
I would expect the tutorial.md to mention bpf2c, and this PR to then update the debugging.md doc accordingly.

@Alan-Jowett
Copy link
Member Author

While the changes look good, I'm concerned about the "Documentation: No" in the PR description. I checked the docs, and the README says:

See our basic eBPF tutorial and our tutorial on debugging eBPF verification failures.

However, neither of those mention bpf2c, and I believe both walkthroughs would eventually fail on a native-only build. I would expect the tutorial.md to mention bpf2c, and this PR to then update the debugging.md doc accordingly.

I agree that our getting started and debugging docs are out-of-date with respect to native only builds. I agree that we should update them, but I am not sure this PR is the correct vehicle for that. Filed #4146

@Alan-Jowett Alan-Jowett enabled auto-merge January 17, 2025 19:05
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Jan 18, 2025
Merged via the queue into microsoft:main with commit 5f890b1 Jan 18, 2025
91 checks passed
@Alan-Jowett Alan-Jowett deleted the issue3879 branch January 18, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bpf2c needs better diagnostics support.
4 participants