Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Sso for SharePoint bot ACEs #4806

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bentsai10
Copy link
Collaborator

Fixes
This change allows SharePoint Bot Driven Aces to use SSO.

Description
Currently a bot driven ace in SharePoint can only use the magic code flow. This flow is not ideal as it requires a user to copy and paste a code from a different window or at a minimum we get flicker of the window being shown. This change allows us to use the SSO flow so that not authentication prompts are shown.

#minor

Specific Changes
Adds a new cardExtension/token activity for doing a token exchange.

Testing

@bentsai10 bentsai10 requested a review from a team as a code owner December 3, 2024 15:02
@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12302726031

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 57 (12.28%) changed or added relevant lines in 5 files are covered.
  • 153 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.6%) to 84.055%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/sharepoint/sharePointActivityHandler.ts 0 3 0.0%
libraries/botbuilder/src/sharepoint/sharePointSSOTokenExchangeMiddleware.ts 4 51 7.84%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/staticChecker.ts 1 98.04%
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts 1 98.46%
libraries/botbuilder-lg/src/customizedMemory.ts 1 96.77%
libraries/botbuilder/src/fileTranscriptStore.ts 1 98.11%
libraries/botbuilder-lg/src/evaluationOptions.ts 2 89.33%
libraries/botbuilder-lg/src/templates.ts 5 96.81%
libraries/botframework-config/src/encrypt.ts 5 88.71%
libraries/botbuilder-lg/src/templateExtensions.ts 5 88.46%
libraries/botbuilder-lg/src/templatesParser.ts 10 91.79%
libraries/botbuilder-dialogs-adaptive-runtime-core/src/serviceCollection.ts 11 70.59%
Totals Coverage Status
Change from base Build 12051547941: -0.6%
Covered Lines: 20438
Relevant Lines: 23148

💛 - Coveralls

@bentsai10 bentsai10 changed the title Support Sso for SharePoint bot ACEs Feat: Support Sso for SharePoint bot ACEs Dec 3, 2024
@bentsai10 bentsai10 changed the title Feat: Support Sso for SharePoint bot ACEs feat: Support Sso for SharePoint bot ACEs Dec 3, 2024
@tracyboehrer
Copy link
Member

tracyboehrer commented Dec 10, 2024

@ceciliaavila and team. Can you review this PR and look into the test failures?

I believe this should bring JS SDK to parity with Dotnet for Sharepoint.

@bentsai10
Copy link
Collaborator Author

@ceciliaavila Bumping this one for help with unblocking, thank you!

Copy link
Collaborator

@ceciliaavila ceciliaavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I just mentioned some small details.
@tracyboehrer, the test check failed with a transient error in the coverage step. The tests passed.

@bentsai10
Copy link
Collaborator Author

@ceciliaavila Addressed your comments, thank you!

@bentsai10
Copy link
Collaborator Author

@ceciliaavila @tracyboehrer How can we override/resolve the transient error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants