-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Sso for SharePoint bot ACEs #4806
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 12302726031Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@ceciliaavila and team. Can you review this PR and look into the test failures? I believe this should bring JS SDK to parity with Dotnet for Sharepoint. |
@ceciliaavila Bumping this one for help with unblocking, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I just mentioned some small details.
@tracyboehrer, the test check failed with a transient error in the coverage step. The tests passed.
libraries/botbuilder/src/sharepoint/sharePointSSOTokenExchangeMiddleware.ts
Outdated
Show resolved
Hide resolved
@ceciliaavila Addressed your comments, thank you! |
@ceciliaavila @tracyboehrer How can we override/resolve the transient error? |
Fixes
This change allows SharePoint Bot Driven Aces to use SSO.
Description
Currently a bot driven ace in SharePoint can only use the magic code flow. This flow is not ideal as it requires a user to copy and paste a code from a different window or at a minimum we get flicker of the window being shown. This change allows us to use the SSO flow so that not authentication prompts are shown.
#minor
Specific Changes
Adds a new cardExtension/token activity for doing a token exchange.
Testing