Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MCP adapters to autogen-ext #5251
base: main
Are you sure you want to change the base?
Add MCP adapters to autogen-ext #5251
Changes from 7 commits
775e4a5
8d02713
a895059
71eb1c5
037ad76
c17d7d7
fcc96fa
127b319
2162cc1
c83b985
a6b18fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this functionality be better served by something like the
Workbench
design rather than a one-off factoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workbench seems to be a higher-level concept to me. You could add the tools gathered with the factory method to the workbench if you wanted to. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the
mcp
code locally I was running into the following bug: modelcontextprotocol/python-sdk#169. Have you run into it by any chance?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran this sample:
https://github.com/richard-gyiko/autogen-ext-mcp/blob/main/samples/agent_chat.py and I saw no sign of this bug.