Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Memory and Team an ABC #5149

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Make Memory and Team an ABC #5149

merged 3 commits into from
Jan 22, 2025

Conversation

victordibia
Copy link
Collaborator

Why are these changes needed?

Builds on #5129 to also make base Team class in AgentChat an ABC

Related issue number

Checks

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.50%. Comparing base (74f411e) to head (a2f827a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5149      +/-   ##
==========================================
+ Coverage   70.48%   70.50%   +0.02%     
==========================================
  Files         174      174              
  Lines       11028    11037       +9     
==========================================
+ Hits         7773     7782       +9     
  Misses       3255     3255              
Flag Coverage Δ
unittests 70.50% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victordibia victordibia merged commit 5e9b24c into main Jan 22, 2025
65 checks passed
@victordibia victordibia deleted the team_memory_abs_vd branch January 22, 2025 23:52
@victordibia victordibia mentioned this pull request Feb 5, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants