Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rysweet-unsubscribe-and-agent-tests-4744 #4920

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Jan 7, 2025

Why are these changes needed?

adds unsubscribe api
adds tests for most all of Agent and AgentWorker

Related issue number

closes #4744
closes #4357

Checks

@rysweet rysweet linked an issue Jan 7, 2025 that may be closed by this pull request
@rysweet rysweet requested a review from Copilot January 7, 2025 17:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 105 out of 120 changed files in this pull request and generated 3 comments.

Files not reviewed (15)
  • dotnet/AutoGen.sln: Language not supported
  • dotnet/Directory.Packages.props: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/DevTeam.AgentHost.csproj: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/Properties/launchSettings.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/appsettings.Development.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.Agents/DevTeam.Agents.csproj: Language not supported
  • dotnet/samples/dev-team/DevTeam.Agents/Properties/launchSettings.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.Agents/appsettings.Development.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/Program.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/Developer/Developer.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/ProductManager/ProductManager.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/Program.cs: Evaluated as low risk
  • README.md: Evaluated as low risk
  • dotnet/samples/Hello/HelloAIAgents/Program.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

dotnet/samples/Hello/HelloAgent/Program.cs:59

  • The SayHello method now accepts a CancellationToken, but the Handle method does not pass the cancellationToken to it. Ensure that the cancellationToken is propagated correctly.
public async Task<string> SayHello(string ask, CancellationToken cancellationToken = default)

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 36 lines in your changes missing coverage. Please review.

Project coverage is 70.41%. Comparing base (e0a6a86) to head (d39dee6).

Files with missing lines Patch % Lines
...togen_ext/runtimes/grpc/protos/agent_worker_pb2.py 4.16% 23 Missing ⚠️
..._ext/runtimes/grpc/protos/agent_worker_pb2_grpc.py 50.00% 12 Missing ⚠️
...ext/runtimes/grpc/_worker_runtime_host_servicer.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4920      +/-   ##
==========================================
- Coverage   70.45%   70.41%   -0.05%     
==========================================
  Files         174      174              
  Lines       11017    11041      +24     
==========================================
+ Hits         7762     7774      +12     
- Misses       3255     3267      +12     
Flag Coverage Δ
unittests 70.41% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bring over the tests from pr 4405 Implement remove_subscription in worker runtime
3 participants