-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rysweet-unsubscribe-and-agent-tests-4744 #4920
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 105 out of 120 changed files in this pull request and generated 3 comments.
Files not reviewed (15)
- dotnet/AutoGen.sln: Language not supported
- dotnet/Directory.Packages.props: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/DevTeam.AgentHost.csproj: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/Properties/launchSettings.json: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/appsettings.Development.json: Language not supported
- dotnet/samples/dev-team/DevTeam.Agents/DevTeam.Agents.csproj: Language not supported
- dotnet/samples/dev-team/DevTeam.Agents/Properties/launchSettings.json: Language not supported
- dotnet/samples/dev-team/DevTeam.Agents/appsettings.Development.json: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/Program.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/Developer/Developer.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/ProductManager/ProductManager.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/Program.cs: Evaluated as low risk
- README.md: Evaluated as low risk
- dotnet/samples/Hello/HelloAIAgents/Program.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
dotnet/samples/Hello/HelloAgent/Program.cs:59
- The
SayHello
method now accepts aCancellationToken
, but theHandle
method does not pass thecancellationToken
to it. Ensure that thecancellationToken
is propagated correctly.
public async Task<string> SayHello(string ask, CancellationToken cancellationToken = default)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4920 +/- ##
==========================================
- Coverage 70.45% 70.41% -0.05%
==========================================
Files 174 174
Lines 11017 11041 +24
==========================================
+ Hits 7762 7774 +12
- Misses 3255 3267 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot <[email protected]>
Why are these changes needed?
adds unsubscribe api
adds tests for most all of Agent and AgentWorker
Related issue number
closes #4744
closes #4357
Checks