Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add message context to signature of intervention handler, add more to docs #4882

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Jan 2, 2025

Breaking:

  • This changes the signature of the on_publish and on_send method in the InterventionHandler class to include a message_context parameter instead of an AgentId parameter.

Closes #4003
Related #4349

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.12%. Comparing base (f4382f0) to head (c703351).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/autogen-core/src/autogen_core/_intervention.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4882      +/-   ##
==========================================
+ Coverage   68.07%   68.12%   +0.04%     
==========================================
  Files         161      161              
  Lines       10172    10179       +7     
==========================================
+ Hits         6925     6934       +9     
+ Misses       3247     3245       -2     
Flag Coverage Δ
unittests 68.12% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits jackgerrits requested a review from Copilot January 2, 2025 20:58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • python/packages/autogen-core/docs/src/user-guide/core-user-guide/cookbook/termination-with-intervention.ipynb: Evaluated as low risk
  • python/packages/autogen-core/docs/src/user-guide/core-user-guide/cookbook/tool-use-with-intervention.ipynb: Evaluated as low risk
@jackgerrits jackgerrits changed the title Add message context to signature of intervention handler, add more to docs feat!: Add message context to signature of intervention handler, add more to docs Jan 3, 2025
@jackgerrits jackgerrits merged commit 5b9be79 into main Jan 7, 2025
56 checks passed
@jackgerrits jackgerrits deleted the intervention_signature_docs branch January 7, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for intervention handler
2 participants