Keep accessors as accessors in emitted anonymous class declarations #60853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
For Backlog Bug
Andarist
force-pushed
the
keep-accessors-as-accessors-on-emitted-anonymous-class-declarations
branch
from
d466c50 to
1baa828
Compare
Andarist
commented
Jan 1, 2025
| @@ -14939,6 +14966,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| } | |||
| if (!singleProp) { | |||
| singleProp = prop; | |||
| propFlags = (prop.flags & SymbolFlags.Accessor) || SymbolFlags.Property; | |||
There was a problem hiding this comment.
Perhaps the accessor case should be handled through checkFlags. I'm worried that it would require looking carefully at all call sites that handle accessors to cover for this new case - but maybe I'm worried about it prematurely. Anyway, let me know what you think about it ;)
Andarist
commented
Jan 1, 2025
Comment on lines
+14992
to
+14993
| // classes created by mixins are represented as intersections and overriding a property in a derived class redefines it completely at runtime | ||
| // so a get accessor can't be merged with a set accessor in a base class, for that reason the accessor flags are only used when they are the same in all consistuents |
There was a problem hiding this comment.
perhaps if I'd use a new CheckFlags.SyntheticAccessor that wouldn't really matter as much? I'm not sure if it's even that important of a rule to begin with, I just erred on the safer side of things and maintained the current behavior for this ambiguous case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #60672
fixes #44938
fixes #58790