update to fix analysis panel freeze #938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
AnalysisPanel
component inapp/frontend/src/components/AnalysisPanel/AnalysisPanel.tsx
to improve error handling and ensure the proper handling of undefined values. The most important changes include adding error messages for undefined values and ensuring the proper execution of asynchronous functions.Improvements to error handling:
sourceFileUrl
is undefined and ensuredsetIsFetchingSourceFileBlob(false)
is called in this case.activeCitation
is undefined and setsetActiveCitationObj(undefined)
accordingly.sourceFile
is undefined and threw errors whencitationURL
is undefined in thefetchMarkdownContent
andfetchPlainTextContent
functions.Ensuring proper execution of asynchronous functions:
fetchSourceFileBlob
function to check for undefinedsourceFile
and ensure proper asynchronous execution.Other changes:
iframe
source URL to handlepageNumber
being null or undefined by using the nullish coalescing operator.Fixes #904